[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150826125158.GM8784@linux>
Date: Wed, 26 Aug 2015 18:21:58 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Javi Merino <javi.merino@....com>
Cc: Vaishali Thakkar <vthakkar1994@...il.com>,
Zhang Rui <rui.zhang@...el.com>,
Eduardo Valentin <edubezval@...il.com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] thermal: cpu_cooling: Remove usage of devm functions
On 26-08-15, 13:47, Javi Merino wrote:
> I missed this because I wasn't CCed :( Thankfully, I'll be in
> MAINTAINERS for this soon.
Yeah, I need to resend that patch soon :)
> > - devm_kfree(&cdev->device, load_cpu);
>
> This introduces a memory leak. Keep the kfree() here, you can't drop
> it. Cheers,
> Javi
>
> > - }
> > -
> > *power = static_power + dynamic_power;
> > return 0;
> > +
> > +free:
> > + kfree(load_cpu);
Wouldn't this make that work ?
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists