linux-kernel - Re: [RFC 2/3] firmware_class: split out transaction helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1440692717.2196.123.camel@HansenPartnership.com>
Date:	Thu, 27 Aug 2015 09:25:17 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	linux-efi@...r.kernel.org,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Jones <pjones@...hat.com>
Subject: Re: [RFC 2/3] firmware_class: split out transaction helpers

On Thu, 2015-08-27 at 15:47 +0100, Matt Fleming wrote:
> On Wed, 29 Apr, at 04:10:52PM, James Bottomley wrote:
> > From: James Bottomley <JBottomley@...n.com>
> > 
> > The firmware class contains code to manage an arbitrary sized buffer for
> > discrete read and write operations.  We need precisely this ability to update
> > firmware capsule files (and likely for other transactions as well), so split
> > out the capability into a library helper
> > 
> > Signed-off-by: James Bottomley <JBottomley@...n.com>
> > ---
> >  drivers/base/firmware_class.c      | 117 ++++---------------------------
> >  include/linux/transaction_helper.h |  26 +++++++
> >  lib/Makefile                       |   2 +-
> >  lib/transaction_helper.c           | 137 +++++++++++++++++++++++++++++++++++++
> >  4 files changed, 179 insertions(+), 103 deletions(-)
> >  create mode 100644 include/linux/transaction_helper.h
> >  create mode 100644 lib/transaction_helper.c
> 
> (Sorry, I'm coming to this incredibly late)
> 
> This patch is pretty neat and I wish something like this had existed
> when I originally wrote the EFI capsule patches.
> 
> James, do you have any plans to resubmit this as a non-RFC? If not, do
> you mind if I pick this up and rebase my capsule patches ontop of it?

Sort of, but I was stalled trying to work out how to combine with your
capsule patches.  If you're going to do that work, I can resubmit my
stuff as a patch with all the changes based on the review comments and
then you can do the real work ...

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/