linux-kernel - Re: [LINUX RFC v2 1/4] spi: add support of two chip selects & data stripe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150903121232.GW12027@sirena.org.uk>
Date:	Thu, 3 Sep 2015 13:12:32 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Ranjit Waghmode <ranjit.waghmode@...inx.com>
Cc:	dwmw2@...radead.org, computersforpeace@...il.com,
	michal.simek@...inx.com, soren.brinkmann@...inx.com,
	zajec5@...il.com, ben@...adent.org.uk, marex@...x.de,
	b32955@...escale.com, knut.wohlrab@...bosch.com,
	juhosg@...nwrt.org, beanhuo@...ron.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	harinik@...inx.com, punnaia@...inx.com
Subject: Re: [LINUX RFC v2 1/4] spi: add support of two chip selects & data
 stripe

On Wed, Aug 26, 2015 at 11:56:04AM +0530, Ranjit Waghmode wrote:

> To support dual parallel mode operation of ZynqMP GQSPI controller
> following API's are added inside the core:

As covered in SubmittingPatches please try to make each patch a single
change rather than having multiple separate changes in one commit.

> +	/* Controller may support more than one chip.
> +	 * This flag will enable that feature.
> +	 */
> +#define SPI_MASTER_BOTH_CS		BIT(8)		/* enable both chips */

This isn't saying that the controller supports more than one chip, it's
saying that the controller supports asserting more than one chip select
at once which isn't the same thing.  I'm also not entirely sure that
this makes sense as a separate feature to the data striping one - I'm
struggling to think of a way to use this sensibly separately to that.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)