linux-kernel - [PATCH RESEND 0/1] Revert "spi/doc: spi_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP_9M6973VAtM6WkP7gkzDMnJbRxmmmiCCuSxMU-_aQm4YQZbg@mail.gmail.com>
Date:	Sun, 6 Sep 2015 01:47:21 +0300
From:	Alexey Klimov <alexey.klimov@...aro.org>
To:	Guenter Roeck <linux@...ck-us.net>, linux-spi@...r.kernel.org,
	broonie@...nel.org
Cc:	Alexey Klimov <klimov.linux@...il.com>, djkurtz@...omium.org,
	linux-kernel@...r.kernel.org,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
Subject: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed
 up by kfree"

Hi all,

During review of new SPI drivers I tried to understand connection
between comment "calling spi_master_put() and kfree() to prevent a
memory leak" for spi_alloc_master() in spi.c and why no driver calls
kfree() on error path. Looks like Uwe added this comment and later I
found patch from Guenter that reverted this comment but spi-imx.c was
not fixed for that time. Later in 2013 spi-imx was fixed. Is it
correct time right now to fix comment?

I tried to save authorship of patch from Guenter, added field "From"
and kept signed-off-by and cc. I hope i did it correctly in patch
(sorry for possible inconvenience).
Also marked it as RESEND since it's resend of original patch from 2012 year.

Best regards,
Alexey Klimov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/