linux-kernel - Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150906000640.GR5313@sirena.org.uk>
Date:	Sun, 6 Sep 2015 01:06:40 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Alexey Klimov <alexey.klimov@...aro.org>
Cc:	Guenter Roeck <linux@...ck-us.net>, linux-spi@...r.kernel.org,
	Alexey Klimov <klimov.linux@...il.com>, djkurtz@...omium.org,
	linux-kernel@...r.kernel.org,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be
 followed up by kfree"

On Sun, Sep 06, 2015 at 01:47:21AM +0300, Alexey Klimov wrote:

> During review of new SPI drivers I tried to understand connection
> between comment "calling spi_master_put() and kfree() to prevent a
> memory leak" for spi_alloc_master() in spi.c and why no driver calls
> kfree() on error path. Looks like Uwe added this comment and later I
> found patch from Guenter that reverted this comment but spi-imx.c was
> not fixed for that time. Later in 2013 spi-imx was fixed. Is it
> correct time right now to fix comment?

I'm sorry but I'm not clear what you're talking about here as there's
missing context...  where is this comment you're talking about?

In general please don't send cover letters for single patches, either
add the content to the commit message or put it after the --- if it's
administrative stuff (like SubmittingPatches says).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)