linux-kernel - Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Sep 2015 18:54:01 +0000
From:	James Bottomley <jbottomley@...n.com>
To:	"hch@....de" <hch@....de>
CC:	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"jim.epost@...il.com" <jim.epost@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"agk@...hat.com" <agk@...hat.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"snitzer@...hat.com" <snitzer@...hat.com>,
	"dm-devel@...hat.com" <dm-devel@...hat.com>
Subject: Re: randconfig build error with next-20150908, in
 drivers/md/dm-mpath.c

On Wed, 2015-09-09 at 18:04 +0200, Christoph Hellwig wrote:
> Does this fix the issue for you?  My Kconfig-fu isn't the best,
> but the idea behind this is that dm-mpath will depend on SCSI
> if SCSI_DH is set.  If SCSI_DH is not set it will use the stubs
> and not care about SCSI.

I assume I'm OK to add

Signed-off-by: Christoph Hellwig <hch@....de>

(I'll assume so if you don't reply)

James

> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index b597273..e9ea681 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -393,7 +393,7 @@ config DM_MULTIPATH
>  	# of SCSI_DH if the latter isn't defined but if
>  	# it is, DM_MULTIPATH must depend on it.  We get a build
>  	# error if SCSI_DH=m and DM_MULTIPATH=y
> -	depends on SCSI_DH || !SCSI_DH
> +	depends on !SCSI_DH || SCSI
>  	---help---
>  	  Allow volume managers to support multipath hardware.
>