linux-kernel - Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55F58852.7070108@suse.de>
Date:	Sun, 13 Sep 2015 16:29:38 +0200
From:	Hannes Reinecke <hare@...e.de>
To:	Mike Snitzer <snitzer@...hat.com>,
	James Bottomley <jbottomley@...n.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"agk@...hat.com" <agk@...hat.com>, "hch@....de" <hch@....de>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"jim.epost@...il.com" <jim.epost@...il.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"dm-devel@...hat.com" <dm-devel@...hat.com>
Subject: Re: randconfig build error with next-20150908, in
 drivers/md/dm-mpath.c

On 09/08/2015 08:30 PM, Mike Snitzer wrote:
> On Tue, Sep 08 2015 at  1:34pm -0400,
> James Bottomley <jbottomley@...n.com> wrote:
> 
>> On Tue, 2015-09-08 at 13:23 -0400, Mike Snitzer wrote:
>>> On Tue, Sep 08 2015 at  1:10pm -0400,
>>> Jim Davis <jim.epost@...il.com> wrote:
>>>
>>>> Building with the attached random configuration file,
>>>>
>>>> drivers/built-in.o: In function `activate_path':
>>>> /home/jim/linux-next/drivers/md/dm-mpath.c:1225: undefined reference
>>>> to `scsi_dh_activate'
>>>> drivers/built-in.o: In function `parse_path':
>>>> /home/jim/linux-next/drivers/md/dm-mpath.c:581: undefined reference to
>>>> `scsi_dh_attached_handler_name'
>>>> /home/jim/linux-next/drivers/md/dm-mpath.c:600: undefined reference to
>>>> `scsi_dh_attach'
>>>> /home/jim/linux-next/drivers/md/dm-mpath.c:615: undefined reference to
>>>> `scsi_dh_set_params'
>>>
>>> These DM-mpath changes were staged via linux-scsi.  Cc'ing James and Christoph.
>>
>> [adding linux-scsi]
>>
>> It must be Hannes' dm changes ... you acked them.  I take it the problem
>> is now dm-mpath won't build without CONFIG_SCSI?  How do you want it
>> fixed?  We can either add a Kconfig dependency or try to disentangle
>> them again.
> 
> OK (Hannes' changes).  I'm fine with seeing DM_MULTIPATH depend on
> CONFIG_SCSI.
> 
Indeed, with the switch for having scsi_dh being moved into struct
scsi_device DM_MULTIPATH will now depend on SCSI.

> The Kconfig for DM_MULTIPATH is clearly stale:
> 
>         # nasty syntax but means make DM_MULTIPATH independent
>         # of SCSI_DH if the latter isn't defined but if
>         # it is, DM_MULTIPATH must depend on it.  We get a build
>         # error if SCSI_DH=m and DM_MULTIPATH=y
>         depends on SCSI_DH || !SCSI_DH
> 
> James, if you have a vision for how to fix this please feel free.
> Otherwise, Hannes, care to send a patch to fix this?
> 
Yep, once I'm back in the office on Monday.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/