linux-kernel - Re: [PATCH] ipvs:Fix locking requirements in the function ip_vs_unlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1509120910090.1626@ja.home.ssi.bg>
Date:	Sat, 12 Sep 2015 09:20:21 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Nicholas Krause <xerofoify@...il.com>
cc:	wensong@...ux-vs.org, horms@...ge.net.au, pablo@...filter.org,
	kaber@...sh.net, kadlec@...ckhole.kfki.hu, davem@...emloft.net,
	netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipvs:Fix locking requirements in the function
 ip_vs_unlink_service


	Hello,

On Sat, 12 Sep 2015, Nicholas Krause wrote:

> This fixes locking requirements in the function ip_vs_unlink_service
> to properly use bottom half spinlocking around the call to the function
> __ip_vs_del_service  in order to meet the locking that this paricular
> function requires as stated in it's comments related to locking.

> +	spin_lock_bh(&svc->sched_lock);
>  	__ip_vs_del_service(svc, cleanup);
> +	spin_unlock_bh(&svc->sched_lock);

	BH locking is not needed anymore. Also, sched_lock is
used by schedulers to protect only access to svc->sched_data
fields.

	It seems the comment is outdated after
commit ceec4c381681 ("ipvs: convert services to rcu").

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/