linux-kernel - Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1442039254.2769.2.camel@perches.com>
Date:	Fri, 11 Sep 2015 23:27:34 -0700
From:	Joe Perches <joe@...ches.com>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Staging: rtl8723au: Bool tests don't need
 comparisons

On Sat, 2015-09-12 at 11:19 +0530, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
> Fixed using Coccinelle

Please do the "== false" and "!= false" cases at the same time
or in another patch.

> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -409,7 +409,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
>  
>  		arg |= BIT(7);/* support entry 2~31 */
>  
> -		if (shortGIrate == true)
> +		if (shortGIrate)
>  			arg |= BIT(5);
>  
>  		tx_ra_bitmap |= ((raid<<28)&0xf0000000);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/