linux-kernel - Re: [PATCH v2] atomics,cmpxchg: Privatize the inclusion of asm/cmpxchg.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150913224740.GF19736@linux-q0g1.site>
Date:	Sun, 13 Sep 2015 15:47:40 -0700
From:	Davidlohr Bueso <dave@...olabs.net>
To:	Boqun Feng <boqun.feng@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will.deacon@....com>,
	Jonathan Corbet <corbet@....net>,
	Shradha Shah <sshah@...arflare.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...sers.ca>,
	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	linux-net-drivers@...arflare.com, linux-doc@...r.kernel.org,
	netdev@...r.kernel.org, speakup@...ux-speakup.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH v2] atomics,cmpxchg: Privatize the inclusion of
 asm/cmpxchg.h

On Wed, 09 Sep 2015, Boqun Feng wrote:

>After commit:
>
>atomics: add acquire/release/relaxed variants of some atomic operations
>
>Architectures may only provide {cmp,}xchg_relaxed definitions in
>asm/cmpxchg.h. Other variants, such as {cmp,}xchg, may be built in
>linux/atomic.h, which means simply including asm/cmpxchg.h may not get
>the definitions of all the{cmp,}xchg variants. Therefore, we should
>privatize the inclusions of asm/cmpxchg.h to keep it only included in
>arch/* and replace the inclusions outside with linux/atomic.h
>
>Acked-by: Will Deacon <will.deacon@....com>
>Signed-off-by: Boqun Feng <boqun.feng@...il.com>

fwiw,

Acked-by: Davidlohr Bueso <dave@...olabs.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/