linux-kernel - Re: [PATCH 15/17] thermal: st: allow compile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Sep 2015 19:11:33 -0700
From:	Eduardo Valentin <edubezval@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Rui Zhang <rui.zhang@...el.com>,
	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Nicolas Boichat <drinkcat@...omium.org>,
	Mark Brown <broonie@...nel.org>,
	Fabian Frederick <fabf@...net.be>,
	Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH 15/17] thermal: st: allow compile test

On Fri, Sep 11, 2015 at 10:23:35AM +0100, Lee Jones wrote:
> On Wed, 09 Sep 2015, Eduardo Valentin wrote:
> 
> > Adding COMPILE_TEST flag to st driver to facilitate
> > maintenance.
> > 
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > Cc: Nicolas Boichat <drinkcat@...omium.org>
> > Cc: Mark Brown <broonie@...nel.org>
> > Cc: Fabian Frederick <fabf@...net.be>
> > Cc: Wolfram Sang <wsa@...-dreams.de>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Cc: linux-pm@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Eduardo Valentin <edubezval@...il.com>
> > ---
> >  drivers/thermal/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Sounds reasonable.
> 
> So long as it's been tested and nothing breaks:
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>

Thanks for the review. But now checking the compilation test using bfin
as target, I see several compilation issues.

So, I am leaving this one out for now. It requires further changes.

BR,

> 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 9069cc7..d94b4e9 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -350,7 +350,7 @@ source "drivers/thermal/samsung/Kconfig"
> >  endmenu
> >  
> >  menu "STMicroelectronics thermal drivers"
> > -depends on ARCH_STI && OF
> > +depends on (ARCH_STI || COMPILE_TEST) && OF
> >  source "drivers/thermal/st/Kconfig"
> >  endmenu
> >  
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)