linux-kernel - Re: [PATCH 13/17] thermal: int340x: allow compile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Sep 2015 15:48:00 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Eduardo Valentin <edubezval@...il.com>,
	Rui Zhang <rui.zhang@...el.com>,
	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	"lan,Tianyu" <tianyu.lan@...el.com>,
	Ilkka Koskinen <ilkka.koskinen@...ux.intel.com>
Subject: Re: [PATCH 13/17] thermal: int340x: allow compile test

On Thu, 2015-09-10 at 08:31 +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin <edubezval@...il.com> wrote:
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
> >
> >  config INT340X_THERMAL
> >         tristate "ACPI INT340X thermal drivers"
> > -       depends on X86 && ACPI
> > +       depends on (X86 && ACPI) || COMPILE_TEST
> >         select THERMAL_GOV_USER_SPACE
> >         select ACPI_THERMAL_REL
> >         select ACPI_FAN
> 
> This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
> header file.
> 
> drivers/thermal/int340x_thermal/int3400_thermal.c: In function
> ‘int3400_thermal_get_uuids’:
> drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
> dereferencing pointer to incomplete type
> 
> Missing #include <linux/fs.h>
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
> declaration of function ‘acpi_has_method’
> 
> Missing #include <acpi/acpi_bus.h>
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
> implicit declaration of function ‘acpi_bus_get_device’
> 
> Definition depends on CONFIG_ACPI
> 
Yes. This has dependency on ACPI. We need to also include ACPI modules
to build. For IOSF we need to have stub functions for core calls.

Thanks,
Srinivas

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/