linux-kernel - Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F782D0.6000501@hitachi.com>
Date:	Tue, 15 Sep 2015 11:30:40 +0900
From:	Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>
To:	Mark Salyzyn <salyzyn@...roid.com>, <linux-kernel@...r.kernel.org>
CC:	Tony Luck <tony.luck@...el.com>, Kees Cook <keescook@...omium.org>,
	<linux-api@...r.kernel.org>, Anton Vorontsov <anton@...msg.org>,
	Shuah Khan <shuahkh@....samsung.com>,
	Colin Cross <ccross@...roid.com>, <seiji.aguchi.tr@...achi.com>
Subject: Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

Hello Mark,

Thank you for your advise.

 >> +prlog -n "Checking pmsg file contains TEST_STRING ... "
 > Mark this as 'wish to have'

OK. I'll change it to "Checking pmsg file wishes to have TEST_STRING
... ". Should I change other messages in the same way?

 > Can TEST_STRING be given an unique value each run, so that on the the
 > reboot-comparison run it can be found to be an unique match?

Yes. I'll append /proc/sys/kernel/random/uuid content to TEST_STRING.
I'll also change log directory name from date to the uuid.

 > Also confirm that any previous content (which may be binary) is not
 > present after reboot, and that totally new content is present.

OK.
As for pmsg, they are possible by checking if the /sys/fs/pstore/pmsg
content perfectly matches the TEST_STRING which was written to /dev/pmsg
before reboot. (The TEST_STRING can be left to a regular file before
reboot as well as reboot_flag.) Is it OK?

Best regards,
Hiraku Toyooka


-- 
Hiraku Toyooka
Systems Productivity Research Dept. / Linux Technology Center
Center for Technology Innovation - Systems Engineering, Hitachi Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/