linux-kernel - Re: [PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and route removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1442284004.29883.4.camel@decadent.org.uk>
Date:	Tue, 15 Sep 2015 03:26:44 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Willy Tarreau <w@....eu>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Alexander Sverdlin <alexander.sverdlin@...ia.com>,
	Neil Horman <nhorman@...driver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Vlad Yasevich <vyasevich@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and
 route removal

On Sun, 2015-09-13 at 00:56 +0200, Willy Tarreau wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> 
> [ Upstream commit 29c4afc4e98f4dc0ea9df22c631841f9c220b944 ]
> 
> There is NULL pointer dereference possible during statistics update if the route
> used for OOTB responce is removed at unfortunate time. If the route exists when
> we receive OOTB packet and we finally jump into sctp_packet_transmit() to send
> ABORT, but in the meantime route is removed under our feet, we take "no_route"
> path and try to update stats with IP_INC_STATS(sock_net(asoc->base.sk), ...).
[...]
> [bwh: Backported to 3.2: sctp alway uses init_net]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
[...]

This doesn't make sense in 2.6.32 and it didn't make sense for me to
apply it to 3.2 either!  Since sctp is not using asoc to look up a net
namespace here, the null pointer doesn't get dereferenced.

Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/