linux-kernel - Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue and f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150918170106.GA7636@saruman.tx.rr.com>
Date:	Fri, 18 Sep 2015 12:01:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	<eu@...ipetonello.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Peter Chen <Peter.Chen@...escale.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH] usb: chipidea: udc: improve error handling on ep_queue
 and f_midi

Hi,

On Fri, Sep 18, 2015 at 05:48:45PM +0100, eu@...ipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@...ipetonello.com>
> 
> _ep_queue() didn't check for errors when using add_td_to_list()
> which can fail if dma_pool_alloc fails, thus causing a kernel
> panic when lastnode->ptr is NULL.
> 
> Also f_midi is not checking weather the is an error on usb_ep_queue
> request, ignoring potential problems, such as memory leaks.
> 
> Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com>
> ---
>  drivers/usb/chipidea/udc.c           | 26 +++++++++++++++++++-------
>  drivers/usb/gadget/function/f_midi.c | 11 +++++++++--

why are you patching f_midi.c in a chipidea patch ? Have a read at
Documentation/SubmittingPatches, Documentation/SubmitChecklist

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)