| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com> Date: Mon, 21 Sep 2015 17:18:34 +0200 From: Vincent Stehlé <vincent.stehle@...escale.com> To: <linux-fsdevel@...r.kernel.org> CC: <linux-kernel@...r.kernel.org>, Vincent Stehlé <vincent.stehle@...escale.com>, Oleg Nesterov <oleg@...hat.com>, "Alexander Viro" <viro@...iv.linux.org.uk>, <trivial@...nel.org> Subject: [PATCH] fs/super.c: use && instead of & for warn_on condition This fixes the following sparse warning: fs/super.c:1202:9: warning: dubious: x & !y Bitwise and logical and are equivalent here, but logical was intended. The generated code is identical, with and without CONFIG_LOCKDEP. Signed-off-by: Vincent Stehlé <vincent.stehle@...escale.com> Cc: Oleg Nesterov <oleg@...hat.com> Cc: Alexander Viro <viro@...iv.linux.org.uk> Cc: trivial@...nel.org --- fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/super.c b/fs/super.c index 954aeb8..7ea56de 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait) else ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1); - WARN_ON(force_trylock & !ret); + WARN_ON(force_trylock && !ret); return ret; } EXPORT_SYMBOL(__sb_start_write); -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists