linux-kernel - Re: [PATCH] fs/super.c: use && instead of & for warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Sep 2015 17:40:05 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Vincent Stehlé <vincent.stehle@...escale.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>, trivial@...nel.org
Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition

On 09/21, Vincent Stehlé wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
>  	else
>  		ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> -	WARN_ON(force_trylock & !ret);
> +	WARN_ON(force_trylock && !ret);

OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.

Acked-by: Oleg Nesterov <oleg@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/