linux-kernel - Re: [PATCH] fs/super.c: use && instead of & for warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1512081450580.9922@cbobk.fhfr.pm>
Date:	Tue, 8 Dec 2015 14:51:15 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
cc:	Vincent Stehlé <vincent.stehle@...escale.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition

On Mon, 21 Sep 2015, Oleg Nesterov wrote:

> > --- a/fs/super.c
> > +++ b/fs/super.c
> > @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
> >  	else
> >  		ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
> >
> > -	WARN_ON(force_trylock & !ret);
> > +	WARN_ON(force_trylock && !ret);
> 
> OOPS! yes, this is a typo, thanks! Harmless in this particular case,
> but still.
> 
> Acked-by: Oleg Nesterov <oleg@...hat.com>

Doesn't seem to be in linux-next as of today, so I am taking it now. 
Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/