linux-kernel - Re: [PATCH] staging: skein: Adds * on subsequent lines in block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150921172109.GH10628@io.lakedaemon.net>
Date:	Mon, 21 Sep 2015 17:21:09 +0000
From:	Jason Cooper <jason@...edaemon.net>
To:	"Amber N. Adams" <amber@...eradams.co>
Cc:	gregkh@...uxfoundation.org, eric.rost@...abylon.net,
	colinpatrickcronin@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: skein: Adds * on subsequent lines in block
 comment

On Sun, Sep 20, 2015 at 11:32:06AM -0500, Amber N. Adams wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: Block comments use * on subsequent lines
> +/*
> +Copyright (c) 2010 Werner Dittmann
> 
> Signed-off-by: Amber N. Adams <amber@...eradams.co>
> ---
>  drivers/staging/skein/skein_api.h | 48 +++++++++++++++++++--------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)

Acked-by: Jason Cooper <jason@...edaemon.net>

> diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h
> index 7da8b38..4cf7003 100644
> --- a/drivers/staging/skein/skein_api.h
> +++ b/drivers/staging/skein/skein_api.h
> @@ -1,28 +1,28 @@
> -/*
> -Copyright (c) 2010 Werner Dittmann
> -
> -Permission is hereby granted, free of charge, to any person
> -obtaining a copy of this software and associated documentation
> -files (the "Software"), to deal in the Software without
> -restriction, including without limitation the rights to use,
> -copy, modify, merge, publish, distribute, sublicense, and/or sell
> -copies of the Software, and to permit persons to whom the
> -Software is furnished to do so, subject to the following
> -conditions:
> -
> -The above copyright notice and this permission notice shall be
> -included in all copies or substantial portions of the Software.
> -
> -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> -EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> -OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> -NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> -HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> -WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> -FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> -OTHER DEALINGS IN THE SOFTWARE.
> +/**

nit: the above should be /* instead of /**, but it's not worth a v2.
Thanks for the patch!

thx,

Jason.

> + * Copyright (c) 2010 Werner Dittmann
> + *
> + * Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> 
> -*/
> + */
> 
>  #ifndef SKEINAPI_H
>  #define SKEINAPI_H
> --
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/