linux-kernel - Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Sep 2015 23:29:38 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Marek Belisko <marek@...delico.com>
Cc:	dbaryshkov@...il.com, dwmw2@...radead.org,
	linux-pm@...r.kernel.org, hns@...delico.com,
	linux-kernel@...r.kernel.org, neilb@...e.de,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link
 problems when building as module

Hi Marek,

On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote:
> If either twl4030_charger or twl4030_madc is configured as MODULE,
> we get build (link) errors.
> 
> To solve, the direct call of twl4030_get_madc_conversion() is replaced
> by a call to iio_read_channel_processed().
>
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> Signed-off-by: Marek Belisko <marek@...delico.com>
> ---
> changes from V1: added missing iio_channel_release + document and add new DT bindings

That was fast :) Patchset looks fine to me except for one last
thing: Let's make the iio-channel optional, so that old DT blobs
are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC)
check can be removed, it should no longer be needed with
iio_read_channel_processed().

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)