linux-kernel - Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfyv36mr67fUJKbe1F_rdxRjtvR8M+da0rYCtVTxDgyhKLvSQ@mail.gmail.com>
Date:	Thu, 24 Sep 2015 21:09:15 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Linux PM mailing list <linux-pm@...r.kernel.org>,
	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	LKML <linux-kernel@...r.kernel.org>, Neil Brown <neilb@...e.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems
 when building as module

Hi Sebastian,

On Tue, Sep 22, 2015 at 11:29 PM, Sebastian Reichel <sre@...nel.org> wrote:
> Hi Marek,
>
> On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote:
>> If either twl4030_charger or twl4030_madc is configured as MODULE,
>> we get build (link) errors.
>>
>> To solve, the direct call of twl4030_get_madc_conversion() is replaced
>> by a call to iio_read_channel_processed().
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> Signed-off-by: Marek Belisko <marek@...delico.com>
>> ---
>> changes from V1: added missing iio_channel_release + document and add new DT bindings
>
> That was fast :) Patchset looks fine to me except for one last
> thing: Let's make the iio-channel optional, so that old DT blobs
> are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC)
> check can be removed, it should no longer be needed with
> iio_read_channel_processed().
OK I updated driver code to pass when 'vac' property isn't found in
DT. Should I mark it also
in DT bindings or keep it as it was in v2? Thanks.
>
> -- Sebastian

BR,

marek


-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/