linux-kernel - Re: [PATCH v3 1/2] iio: resistance: Document that resistance can be output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56014FD0.4010005@lysator.liu.se>
Date:	Tue, 22 Sep 2015 14:55:44 +0200
From:	Peter Rosin <peda@...ator.liu.se>
To:	Daniel Baluta <daniel.baluta@...il.com>
Cc:	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Peter Rosin <peda@...ntia.se>, Crt Mori <cmo@...exis.com>,
	Andreas Dannenberg <dannenberg@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] iio: resistance: Document that resistance can be
 output

On 2015-09-22 14:48, Daniel Baluta wrote:
> On Tue, Sep 22, 2015 at 3:39 PM, Peter Rosin <peda@...ator.liu.se> wrote:
>> From: Peter Rosin <peda@...ntia.se>
>>
>> Signed-off-by: Peter Rosin <peda@...ntia.se>
>> ---
>>  Documentation/ABI/testing/sysfs-bus-iio |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index 9398484196c4..2eea468f704d 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1475,6 +1475,8 @@ Description:
>>
>>  What:          /sys/bus/iio/devices/iio:deviceX/in_resistance_raw
>>  What:          /sys/bus/iio/devices/iio:deviceX/in_resistanceX_raw
>> +What:          /sys/bus/iio/devices/iio:deviceX/out_resistance_raw
>> +What:          /sys/bus/iio/devices/iio:deviceX/out_resistanceX_raw
>>  KernelVersion: 4.3
>>  Contact:       linux-iio@...r.kernel.org
>>  Description:
> 
> One more thing. The description for this sections says:
> 
> »       »       Raw (unscaled no offset etc.) resistance reading that
> can be processed
> »       »       into an ohm value.
> 
> I'm not sure this still holds for out_resistanceX_raw. We have two options here:

I figured it did hold, since you effectively select what reading the
resistance inside the potentiometer should have. If it's really
important I can of course make another spin, but is this somthing
that is likely to be misunderstood?

> * remove 'reading' because with the out_ file we are basically setting
> the resistance
> raw value OR
> * add a separate section for out_ files, with proper description.
> 
> Any other comments?
> 
> thanks,
> Daniel.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/