linux-kernel - Re: [PATCH v5] tools lib traceevent: str addresses in heterogeneous arch environments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150922140443.GC2580@redhat.com>
Date:	Tue, 22 Sep 2015 11:04:43 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Kapileshwar Singh <kapileshwar.singh@....com>,
	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>,
	Javi Merino <javi.merino@....com>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH v5] tools lib traceevent: str addresses in heterogeneous
 arch environments

Em Tue, Sep 22, 2015 at 09:46:18AM -0400, Steven Rostedt escreveu:
> On Tue, 22 Sep 2015 14:22:03 +0100
> Kapileshwar Singh <kapileshwar.singh@....com> wrote:
> 
> >  		if (!(field->flags & FIELD_IS_ARRAY) &&
> >  		    field->size == pevent->long_size) {
> > -			addr = *(unsigned long *)(data + field->offset);
> > +
> > +			/* Handle heterogeneous recording and processing
> > +			 * architectures
> > +			 *
> > +			 * CASE I:
> > +			 * Traces recorded on 32-bit devices (32-bit
> > +			 * addressing) and processed on 64-bit devices:
> > +			 * In this case, only 32 bits should be read.
> > +			 *
> > +			 * CASE II:
> > +			 * Traces recorded on 64 bit devices and processed
> > +			 * on 32-bit devices:
> > +			 * In this case, 64 bits must be read.
> 
> Probably should have added a comment about not caring about endianess
> and why, but that can be added later. This patch is good enough for now.
> 
> Reviewed-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Arnaldo, want to pick this up?

Sure, I'm adding it to perf/core, i.e. for 4.4, or do you think this
needs to go into 4.3?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/