linux-kernel - Re: [linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560165EC.4050208@redhat.com>
Date:	Tue, 22 Sep 2015 16:30:04 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Chen-Yu Tsai <wens@...e.org>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS

Hi,

On 22-09-15 16:04, Maxime Ripard wrote:
> On Tue, Sep 22, 2015 at 03:01:58PM +0200, Hans de Goede wrote:
>>> In short, this is not about "power supply" but VBUS detection. IIRC,
>>> if no VBUS detection method is provided, the phy driver just waits a
>>> period of time after an ID pin change and then considers VBUS invalid.
>>
>> Right, but that is a hack for boards with no / broken vbus detection
>> (or vbus control), we really want to use vbus-det where available,
>> so I agree that a TODO comment here would be good.
>
> What's so special in our SoCs that makes that we can't just rely on
> the ID pin ? (which seems to be working just fine here)

There is nothing special, AFAIK all OTG ports (also for other SoCs)
have some sort of vbus detection mechanism. We need the hack because
vbus-det is broken on some of our boards.

And where it is not broken we should be using vbus-det normallu.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/