linux-kernel - Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and findfs objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923083906.GB2024@krava.redhat.com>
Date:	Wed, 23 Sep 2015 10:39:06 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Vinson Lee <vlee@...pensource.com>, rostedt@...dmis.org,
	Jiri Olsa <jolsa@...nel.org>, raphael.beamonte@...il.com,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Namhyung Kim <namhyung@...nel.org>,
	linux-tip-commits@...r.kernel.org,
	Michael Petlan <mpetlan@...hat.com>
Subject: Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and
 findfs objects

On Wed, Sep 23, 2015 at 09:23:02AM +0100, Matt Fleming wrote:
> On Mon, 21 Sep, at 05:20:03PM, Vinson Lee wrote:
> > On Mon, Sep 14, 2015 at 11:59 PM, tip-bot for Jiri Olsa
> > <tipbot@...or.com> wrote:
> > > Commit-ID:  60a1133a5b39738671eff1e4d77bedc1ee3fa528
> > > Gitweb:     http://git.kernel.org/tip/60a1133a5b39738671eff1e4d77bedc1ee3fa528
> > > Author:     Jiri Olsa <jolsa@...nel.org>
> > > AuthorDate: Wed, 2 Sep 2015 09:56:44 +0200
> > > Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
> > > CommitDate: Mon, 14 Sep 2015 12:50:15 -0300
> > >
> > > tools lib api fs: Remove debugfs, tracefs and findfs objects
> > >
> > > We have all the functionality in fs.c, let's remove unneeded
> > > objects.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > > Cc: David Ahern <dsahern@...il.com>
> > > Cc: Matt Fleming <matt@...eblueprint.co.uk>
> > > Cc: Namhyung Kim <namhyung@...nel.org>
> > > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > > Cc: Raphael Beamonte <raphael.beamonte@...il.com>
> > > Cc: Steven Rostedt <rostedt@...dmis.org>
> > > Link: http://lkml.kernel.org/r/1441180605-24737-15-git-send-email-jolsa@kernel.org
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > 
> > Hi.
> > 
> > This commit seems to have introduced a build failure with tools/vm.
> > 
> > $ make -C tools vm
> > [...]
> > gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libapi.a
> > page-types.c:45:28: fatal error: api/fs/debugfs.h: No such file or directory
> >  #include <api/fs/debugfs.h>
> 
> Given the ferocious pace of development of tools/perf, is there not
> some kind of automated build that happens when new patches are picked
> up, before they're pushed out?
> 
> Things are refactored and changed so fast in this area (I dare say
> faster than almost any other part of the kernel source tree) that not
> having the safety net of automated builds just seems suicidal.
> 
> And that doesn't even begin to cover runtime testing, since I've
> noticed things breaking in tools/perf and people not catching it
> immediately.
> 
> Does automated testing exist for perf tools development?

heh, we've been playing game "who first mention it in public will implement it" ... you won! ;-)

AFAIK we have: 
  - 'perf test' for perf specific functionality
  - 'make -f tests/make' for building
  - build framework tests

I 'try' to run those before sending anything out, but we dont have
automated thing that would run it any time Arnaldo push new perf/core.

The RedHat QE has some more perf tool tests. There was some movement
to make those public, but not sure how it ended up.. ccing Michael Petlan
for news on this ;-)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/