linux-kernel - Re: [patch] mm, oom: remove task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923091354.GA640@swordfish>
Date:	Wed, 23 Sep 2015 18:13:54 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Michal Hocko <mhocko@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kyle Walker <kwalker@...hat.com>,
	Christoph Lameter <cl@...ux.com>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-mm <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Stanislav Kozina <skozina@...hat.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Subject: Re: [patch] mm, oom: remove task_lock protecting comm printing

On (09/23/15 11:06), Vladimir Davydov wrote:
> Hi,
> 
> On Tue, Sep 22, 2015 at 04:30:13PM -0700, David Rientjes wrote:
> > The oom killer takes task_lock() in a couple of places solely to protect
> > printing the task's comm.
> > 
> > A process's comm, including current's comm, may change due to
> > /proc/pid/comm or PR_SET_NAME.
> > 
> > The comm will always be NULL-terminated, so the worst race scenario would
> > only be during update.  We can tolerate a comm being printed that is in
> > the middle of an update to avoid taking the lock.
> > 
> > Other locations in the kernel have already dropped task_lock() when
> > printing comm, so this is consistent.
> 
> Without the protection, can't reading task->comm race with PR_SET_NAME
> as described below?

the previous name was already null terminated, so it should be

	[name\0old_name\0]

	-ss

> 
> Let T->comm[16] = "name\0rubbish1234"
> 
> CPU1                                    CPU2
> ----                                    ----
> set_task_comm(T, "longname\0")
>   T->comm[0] = 'l'
>   T->comm[1] = 'o'
>   T->comm[2] = 'n'
>   T->comm[3] = 'g'
>   T->comm[4] = 'n'
>                                         printk("%s\n", T->comm)
>                                           T->comm = "longnrubbish1234"
>                                           OOPS: the string is not
>                                                 nil-terminated!
>   T->comm[5] = 'a'
>   T->comm[6] = 'm'
>   T->comm[7] = 'e'
>   T->comm[8] = '\0'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/