linux-kernel - Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2015 10:15:42 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	Sudeep Holla <sudeep.holla@....com>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	Rafael Wysocki <rjw@...ysocki.net>,
	"sboyd@...eaurora.org" <sboyd@...eaurora.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	"open list:ACPI" <linux-acpi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"Zheng, Lv" <lv.zheng@...el.com>
Subject: Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms
 using 'global_lock'



On 15/09/15 09:34, Viresh Kumar wrote:
> global_lock is defined as an unsigned long and accessing only its lower
> 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> for big endian 64 bit systems.
>
> Fix that by making global_lock an u32 instead.
>
> Cc: <stable@...r.kernel.org>  # v4.1+
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> ---
> Its marked just for # v4.1+, because arm64 has the first 64 big-endian
> platform with ACPI. And ACPI support for that is mainlined recently
> only (Arnd Bergmann).
>

Just to clarify, we don't support big-endian with ACPI on ARM64.
We mandate use of EFI for ACPI on ARM64 and EFI spec mandates only
little endian.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/