linux-kernel - Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2015 12:26:36 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"J. German Rivera" <German.Rivera@...escale.com>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	stuart.yoder@...escale.com, itai.katz@...escale.com,
	leoli@...escale.com, scottwood@...escale.com, agraf@...e.de,
	bhamciu1@...escale.com, R89243@...escale.com,
	bhupesh.sharma@...escale.com, nir.erez@...escale.com,
	richard.schmitt@...escale.com
Subject: Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to
 v4.0

On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
>  /**
> + * dprc_set_obj_label() - Set object label.
> + * @mc_io:	Pointer to MC portal's I/O object
> + * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token:	Token of DPRC object
> + * @obj_type:	Object's type
> + * @obj_id:	Object's ID
> + * @label:	The required label. The maximum length is 16 chars.
> + *
> + * Return:	'0' on Success; Error code otherwise.
> + */
> +int dprc_set_obj_label(struct fsl_mc_io	*mc_io,
> +		       uint32_t		cmd_flags,
> +		       uint16_t		token,
> +		       char		*obj_type,
> +		       int		obj_id,
> +		       char		*label);

You can fix it in a later patch, but this documentation belongs in the
.c file instead of the .h file.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/