[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CY1PR0301MB1307BFE6DCA9C8453AA75CF8FE430@CY1PR0301MB1307.namprd03.prod.outlook.com>
Date: Thu, 24 Sep 2015 18:39:10 +0000
From: Jose Rivera <German.Rivera@...escale.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"arnd@...db.de" <arnd@...db.de>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Stuart Yoder <stuart.yoder@...escale.com>,
Katz Itai <itai.katz@...escale.com>,
Li Leo <LeoLi@...escale.com>,
Scott Wood <scottwood@...escale.com>,
"agraf@...e.de" <agraf@...e.de>,
Hamciuc Bogdan <bhamciu1@...escale.com>,
Marginean Alexandru <R89243@...escale.com>,
Sharma Bhupesh <bhupesh.sharma@...escale.com>,
"Erez Nir" <nir.erez@...escale.com>,
Richard Schmitt <richard.schmitt@...escale.com>
Subject: RE: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to
v4.0
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@...cle.com]
> Sent: Wednesday, September 23, 2015 4:27 AM
> To: Rivera Jose-B46482
> Cc: gregkh@...uxfoundation.org; arnd@...db.de;
> devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org; Yoder Stuart-
> B08248; katz Itai-RM05202; Li Yang-Leo-R58472; Wood Scott-B07421;
> agraf@...e.de; Hamciuc Bogdan-BHAMCIU1; Marginean Alexandru-R89243;
> Sharma Bhupesh-B45370; Erez Nir-RM30794; Schmitt Richard-B43082
> Subject: Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface
> to v4.0
>
> On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
> > /**
> > + * dprc_set_obj_label() - Set object label.
> > + * @mc_io: Pointer to MC portal's I/O object
> > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> > + * @token: Token of DPRC object
> > + * @obj_type: Object's type
> > + * @obj_id: Object's ID
> > + * @label: The required label. The maximum length is 16 chars.
> > + *
> > + * Return: '0' on Success; Error code otherwise.
> > + */
> > +int dprc_set_obj_label(struct fsl_mc_io *mc_io,
> > + uint32_t cmd_flags,
> > + uint16_t token,
> > + char *obj_type,
> > + int obj_id,
> > + char *label);
>
> You can fix it in a later patch, but this documentation belongs in the .c
> file instead of the .h file.
>
Thanks Dan. We will submit a patch for this.
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists