linux-kernel - Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Sep 2015 13:17:53 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	<linux-kernel@...r.kernel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-omap@...r.kernel.org>, <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform
 driver



On 18/09/15 21:44, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> index 90cbc4c..c581231 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
>  	{ .compatible = "omapdss,sony,acx565akm", },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>  
>  static struct spi_driver acx565akm_driver = {
>  	.driver = {
> 

Thanks, queued for 4.3 fixes.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)