linux-kernel - Re: [PATCH] video: fbdev: mb862xx: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5603CDE0.5050708@ti.com>
Date:	Thu, 24 Sep 2015 13:18:08 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	<linux-kernel@...r.kernel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Wolfram Sang <wsa@...-dreams.de>, <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: mb862xx: Fix module autoload for OF
 platform driver



On 18/09/15 21:46, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index 9b8bebd..f9ec5c0 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -831,6 +831,7 @@ static struct of_device_id of_platform_mb862xx_tbl[] = {
>  	{ .compatible = "fujitsu,coral", },
>  	{ /* end */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_platform_mb862xx_tbl);
>  
>  static struct platform_driver of_platform_mb862xxfb_driver = {
>  	.driver = {
> 

Thanks, queued for 4.3 fixes.

Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)