linux-kernel - Re: [PATCH 2/3] EDAC, amd64_edac: Extend scrub rate programmability feature for F15hM60h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Sep 2015 11:42:20 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<mchehab@....samsung.com>, <dougthompson@...ssion.com>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] EDAC, amd64_edac: Extend scrub rate programmability
 feature for F15hM60h

On 9/24/2015 11:33 AM, Borislav Petkov wrote:
>
>
> And that's ugly - I much prefer having input arguments being input only
> and return values being return values only. If it can be helped, that
> is. And in this case, it is not necessary.

Okay, I'll fix this in the next version and do a family check in 
__set_scrub_rate() itself.

>
> Yeah, I believe we've talked about this before: a patch should do one
> logical change and one logical change *only* - no other unrelated hunks
> belong in it.
>
> Otherwise, they make reviewing it harder by making me wonder why is that
> hunk there and what does it have to do with the scrub rate changes.
> Unrelated hunks can - further down the road - complicate bisection and
> cherry-picking for other kernels.
>
> So please try to restrain yourself to do solely the one logical change
> your patch addresses.
>
> If you feel that some more work needs to be done on the file or the
> whole driver, you can always send *separate* patches ontop which we can
> discuss.
>

Okay, Sorry about that.

Will clean it up in V2.

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/