linux-kernel - Re: [PATCH] pinctrl: sort dt_params array in the same order as pin_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYZ1sR-XiOdniK=gwJWP2kWh+JH0of_xaxJqcb2UJPkrg@mail.gmail.com>
Date:	Thu, 24 Sep 2015 09:40:05 -0700
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Cc:	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: sort dt_params array in the same order as pin_config_param

On Tue, Sep 22, 2015 at 9:39 PM, Bjorn Andersson
<bjorn.andersson@...ymobile.com> wrote:
> On Sun 20 Sep 09:26 PDT 2015, Masahiro Yamada wrote:

>> +     { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 },
>>       { "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 },
>>       { "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 },
>>       { "output-low", PIN_CONFIG_OUTPUT, 0, },
>>       { "output-high", PIN_CONFIG_OUTPUT, 1, },
>> -     { "slew-rate", PIN_CONFIG_SLEW_RATE, 0},
>
> I would like to see these alphabetically sorted instead and looking at
> most of the entries that's already the case.
>
> The order of the lists in this file the order doesn't matter, so that's
> easy. There's some potential implications of renumbering the enum, but I
> think it's worth keeping them sorted as well.

I agree. Dropping this for a better fix, patches accepted :)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/