linux-kernel - Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150928132159.4738f573@bbrezillon>
Date:	Mon, 28 Sep 2015 13:21:59 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@...ron.com>
Cc:	"dedekind1@...il.com" <dedekind1@...il.com>,
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>,
	"baruch@...s.co.il" <baruch@...s.co.il>,
	"asierra@...-inc.com" <asierra@...-inc.com>,
	"guz.fnst@...fujitsu.com" <guz.fnst@...fujitsu.com>,
	"gsi@...x.de" <gsi@...x.de>, "richard@....at" <richard@....at>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"Frank Liu 刘群 (frankliu)" <frankliu@...ron.com>,
	Andrea Scian <rnd4@...e-tech.it>,
	"Peter Pan 潘柏宏 (peterpan)" <peterpan@...ron.com>,
	"Karl Zhang 张双锣 (karlzhang)" 
	<karlzhang@...ron.com>,
	Iwo Mergler <Iwo.Mergler@...commwireless.com>,
	"Jeff Lauruhn (jlauruhn)" <jlauruhn@...ron.com>,
	Stefan Roese <sr@...x.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer

On Mon, 28 Sep 2015 07:02:52 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@...ron.com> wrote:

> Add hook for UBI bakvol in ubifs layer.
> 
> open/close bakvol operation in ubifs mount.
> 
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>  fs/ubifs/super.c | 6 ++++++
>  fs/ubifs/ubifs.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 9547a278..f3bf548 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1463,6 +1463,8 @@ static int mount_ubifs(struct ubifs_info *c)
>  	dbg_gen("max. seq. number:    %llu", c->max_sqnum);
>  	dbg_gen("commit number:       %llu", c->cmt_no);
>  
> +	init_bakvol(c->ubi, 1);

This function is implemented in patch 9 and you're using it here, which
means your series is not bisectable.

Also, do we really want to let UBIFS decide whether this feature should
be enabled or not for the whole UBI device?

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/