lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150928112346.GB10335@sudip-pc> Date: Mon, 28 Sep 2015 16:53:46 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Mateusz Kulikowski <mateusz.kulikowski@...il.com> Cc: Larry.Finger@...inger.net, Jes.Sorensen@...hat.com, devel@...verdev.osuosl.org, gregkh@...uxfoundation.org, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rtl8723au: Fix resource leak On Sun, Sep 27, 2015 at 09:30:54PM +0200, Mateusz Kulikowski wrote: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com> > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > index cd014f7..87bb87f 100644 > --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > @@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter) > goto Exit; > } > firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL); > + release_firmware(fw); > if (!firmware_buf) { > rtStatus = _FAIL; > goto Exit; > } > buf = firmware_buf; > fw_size = fw->size; > - release_firmware(fw); You are releasing the firmware and then accessing fw->size here. That just introduced a NULL pointer dereference. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists