linux-kernel - Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1803658.W77SUJGE4K@wuerfel>
Date:	Mon, 28 Sep 2015 21:38:33 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Rob Herring <robh@...nel.org>
Cc:	Ley Foon Tan <lftan@...era.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Russell King <linux@....linux.org.uk>,
	Marc Zyngier <marc.zyngier@....com>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

On Monday 28 September 2015 12:31:36 Rob Herring wrote:
> >> > +
> >> > +Required properties:
> >> > +- compatible :       should contain "altr,pcie-root-port-1.0"
> >> > +- reg:               a list of physical base address and length for TXS and CRA.
> >> > +- reg-names: must include the following entries:
> >> > +             "Txs" or "txs": TX slave port region
> >> > +             "Cra" or "cra": Control register access region
> >>
> >> Why both cases? Can we please just have one (or none is better IMO).
> > The PCIe IP on different device families use different register names.
> > And our device tree generator will auto generate the register names
> > based on the hardware description name. Too bad we can't change the
> > hardware description names now.
> 
> Okay, your problem to maintain. Hopefully the driver just goes by index then.
> 
> Strictly speaking, if you have undocumented bindings downstream that
> is your problem and we don't have to accept them as-is upstream. I'm
> not going to worry about that here.

Are they always in the same order? If you don't mandate any names for the
registers in the binding but just use them by index, we can keep that
bit of ugliness out of the binding and the driver and still be compatible
with all the devices.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/