linux-kernel - Re: [PATCH 1/2] nios2: Add architectural support for PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFiDJ5-z9-qU3i2pXUg+Sx4pP93xDGrp-5AwYEnO8CUn6bhDog@mail.gmail.com>
Date:	Tue, 29 Sep 2015 18:00:18 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/2] nios2: Add architectural support for PCIe

On Tue, Sep 29, 2015 at 3:37 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 29 September 2015 11:12:24 Ley Foon Tan wrote:
>> >
>> > I think that would be good, yes. We probably picked defaults for the
>> > asm-generic version that are enough to build with CONFIG_PCI disabled,
>> > but there are useful defaults for the other case as well.
>> >
>> > Most architectures that use the file don't support PCI, so you can just
>> > add stuff inside of #ifdef CONFIG_PCI. For the remaining 13 architectures
>> > (git grep -l generic/pci.h  | wc), see whether there are conflicts first.
>> > The normal way would be to have the arch specific definition come before
>> > the #include, and then do something like
>> >
>> > #ifndef pci_proc_domain
>> > #define pci_proc_domain pci_proc_domain
>> > static inline int pci_proc_domain(struct pci_bus *bus)
>> > {
>> > #ifdef CONFIG_PCI_DOMAINS_GENERIC
>> >         return pci_domain_nr(bus);
>> > #else
>> >         return 1;
>> > }
>> > #endif
>>
>> Okay, will try add them to asm-generic.
>
> Thanks
>
>> Do you prefer to send it as separate patch or can be part of this patchset?
>
> I prefer the patches to be part of this series and merged through together
> with them.
>
Okay, will send a new version later.

Thanks.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/