linux-kernel - Re: [PATCH] extcon: arizona: Reorder the default statement to remove unnecessary warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150929100852.GH5432@ck-lbox>
Date:	Tue, 29 Sep 2015 11:08:52 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Chanwoo Choi <cwchoi00@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <rf@...nsource.wolfsonmicro.com>,
	<cw00.choi@...sung.com>
Subject: Re: [PATCH] extcon: arizona: Reorder the default statement to
 remove unnecessary warning

On Tue, Sep 29, 2015 at 07:06:31PM +0900, Chanwoo Choi wrote:
> This patch reorders the default statement to remove unnecessary warning message
> when info->hpdet_ip_version is 2.

Should say is higher than 2.

> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---

But otherwise looks fine, the intention I imagine was to print a
warning for unknown hpdep ip but still handle it as ip version 2.
But given that the ip can only be unknown if there has been a
mistake coding the driver return EINVAL seems fine too.

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles

>  drivers/extcon/extcon-arizona.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index b010307..a1ab0a5 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -477,9 +477,6 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
>  			   arizona_hpdet_b_ranges[range].factor_a);
>  		break;
>  
> -	default:
> -		dev_warn(arizona->dev, "Unknown HPDET IP revision %d\n",
> -			 info->hpdet_ip_version);
>  	case 2:
>  		if (!(val & ARIZONA_HP_DONE_B)) {
>  			dev_err(arizona->dev, "HPDET did not complete: %x\n",
> @@ -516,6 +513,12 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
>  				arizona_hpdet_c_ranges[range].min);
>  			val = arizona_hpdet_c_ranges[range].min;
>  		}
> +		break;
> +
> +	default:
> +		dev_warn(arizona->dev, "Unknown HPDET IP revision %d\n",
> +			 info->hpdet_ip_version);
> +		return -EINVAL;
>  	}
>  
>  	dev_dbg(arizona->dev, "HP impedance %d ohms\n", val);
> -- 
> 2.2.0.GIT
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/