| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1443525723-6323-1-git-send-email-luisbg@osg.samsung.com> Date: Tue, 29 Sep 2015 12:22:03 +0100 From: Luis de Bethencourt <luisbg@....samsung.com> To: linux-kernel@...r.kernel.org Cc: abbotti@....co.uk, hsweeten@...ionengravers.com, gregkh@...uxfoundation.org, surya.seetharaman9@...il.com, devel@...verdev.osusl.org, Luis de Bethencourt <luisbg@....samsung.com> Subject: [PATCH v2] staging: comedi: ni_tiocmd: remove unused code Code after a return will never run, removing this dead code. Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com> --- Hi, This is a better fix than the previous patch: http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02741.html Suggestion of just removing the dead code was in: http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02939.html Thanks, Luis drivers/staging/comedi/drivers/ni_tiocmd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c index 9b124b0..437f723 100644 --- a/drivers/staging/comedi/drivers/ni_tiocmd.c +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c @@ -157,12 +157,6 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s) dev_err(counter->counter_dev->dev->class_dev, "output commands not yet implemented.\n"); return -ENOTSUPP; - - counter->mite_chan->dir = COMEDI_OUTPUT; - mite_prep_dma(counter->mite_chan, 32, 32); - ni_tio_configure_dma(counter, true, false); - mite_dma_arm(counter->mite_chan); - return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE); } static int ni_tio_cmd_setup(struct comedi_subdevice *s) -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists