linux-kernel - Re: [PATCH v2] staging: comedi: ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <560BF17E.6040806@mev.co.uk>
Date:	Wed, 30 Sep 2015 15:28:14 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Luis de Bethencourt <luisbg@....samsung.com>,
	linux-kernel@...r.kernel.org
CC:	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
	surya.seetharaman9@...il.com, devel@...verdev.osusl.org
Subject: Re: [PATCH v2] staging: comedi: ni_tiocmd: remove unused code

On 29/09/15 12:22, Luis de Bethencourt wrote:
> Code after a return will never run, removing this dead code.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>
> Hi,
>
> This is a better fix than the previous patch:
> http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02741.html
>
> Suggestion of just removing the dead code was in:
> http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02939.html
>
> Thanks,
> Luis
>
>   drivers/staging/comedi/drivers/ni_tiocmd.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
> index 9b124b0..437f723 100644
> --- a/drivers/staging/comedi/drivers/ni_tiocmd.c
> +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
> @@ -157,12 +157,6 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s)
>   	dev_err(counter->counter_dev->dev->class_dev,
>   		"output commands not yet implemented.\n");
>   	return -ENOTSUPP;
> -
> -	counter->mite_chan->dir = COMEDI_OUTPUT;
> -	mite_prep_dma(counter->mite_chan, 32, 32);
> -	ni_tio_configure_dma(counter, true, false);
> -	mite_dma_arm(counter->mite_chan);
> -	return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE);
>   }
>
>   static int ni_tio_cmd_setup(struct comedi_subdevice *s)
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/