lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 29 Sep 2015 14:59:03 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Brent Adam <brentadamdev@...il.com>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Brent Adam <brentadam@...rttech.com>
Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

On Mon, 28 Sep 2015, Brent Adam wrote:

> Fixed the following checkpatch.pl warnings:
> WARNING: line over 80 characters: line 163
> WARNING: Missing a blank line after declarations: line 359
> WARNING: Missing a blank line after declarations: line 572
> WARNING: Missing a blank line after declarations: line 708
> WARNING: Missing a blank line after declarations: line 926
> WARNING: Possible unnecessary 'out of memory' message: line 1034
> WARNING: Possible unnecessary 'out of memory' message: line 1048
> WARNING: line over 80 characters: line 1390

For files which are already in tree I'd be taking such fixes only as a 
side-change if refactoring the code anyway in a substantial way. Otherwise 
I consider the ones below too minor to justify cluttering of git blame.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ