linux-kernel - Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C29E0AF0-087D-418B-B1FD-87A7392BF3C8@smarttech.com>
Date:	Tue, 29 Sep 2015 14:13:51 +0000
From:	Brent Adam <BrentAdam@...rttech.com>
To:	Jiri Kosina <jikos@...nel.org>
CC:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings



On 9/29/15, 6:59 AM, "Jiri Kosina" <jikos@...nel.org> wrote:

>On Mon, 28 Sep 2015, Brent Adam wrote:
>
>> Fixed the following checkpatch.pl warnings:
>> WARNING: line over 80 characters: line 163
>> WARNING: Missing a blank line after declarations: line 359
>> WARNING: Missing a blank line after declarations: line 572
>> WARNING: Missing a blank line after declarations: line 708
>> WARNING: Missing a blank line after declarations: line 926
>> WARNING: Possible unnecessary 'out of memory' message: line 1034
>> WARNING: Possible unnecessary 'out of memory' message: line 1048
>> WARNING: line over 80 characters: line 1390
>
>For files which are already in tree I'd be taking such fixes only as a 
>side-change if refactoring the code anyway in a substantial way. Otherwise 
>I consider the ones below too minor to justify cluttering of git blame.


Ok, although Greg Kroah-Hartman inspires you in his video to submit patches
to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4

-Brent