[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1509300954370.30132@pobox.suse.cz>
Date: Wed, 30 Sep 2015 09:55:23 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Brent Adam <BrentAdam@...rttech.com>
cc: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings
On Tue, 29 Sep 2015, Brent Adam wrote:
> >> Fixed the following checkpatch.pl warnings:
> >> WARNING: line over 80 characters: line 163
> >> WARNING: Missing a blank line after declarations: line 359
> >> WARNING: Missing a blank line after declarations: line 572
> >> WARNING: Missing a blank line after declarations: line 708
> >> WARNING: Missing a blank line after declarations: line 926
> >> WARNING: Possible unnecessary 'out of memory' message: line 1034
> >> WARNING: Possible unnecessary 'out of memory' message: line 1048
> >> WARNING: line over 80 characters: line 1390
> >
> >For files which are already in tree I'd be taking such fixes only as a
> >side-change if refactoring the code anyway in a substantial way. Otherwise
> >I consider the ones below too minor to justify cluttering of git blame.
>
> Ok, although Greg Kroah-Hartman inspires you in his video to submit patches
> to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4
HID is not a subsystem residing in drivers/staging playground though.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists