linux-kernel - Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Sep 2015 15:55:38 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Baoquan He <bhe@...hat.com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the
 parse_ioapics_under_ir

On Tue, Sep 29, 2015 at 03:26:09PM +0800, Baoquan He wrote:
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 37b93f5..0f441b7 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void)
>  	if (!dmar_ir_support())
>  		return -ENODEV;
>  
> -	if (parse_ioapics_under_ir() != 1) {
> +	if (!parse_ioapics_under_ir()) {
>  		pr_info("Not enabling interrupt remapping\n");
>  		goto error;
>  	}
> @@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void)
>  		}
>  
>  	if (!ir_supported)
> -		return 0;
> +		return -1;
>  
>  	for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
>  		int ioapic_id = mpc_ioapic_id(ioapic_idx);
> @@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void)
>  		}
>  	}
>  
> -	return 1;
> +	return 0;

Looks good, but -ENODEV is probably a better return value than -1.


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/