linux-kernel - Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150929150438.GA2011@dhcp-17-102.nay.redhat.com>
Date:	Tue, 29 Sep 2015 23:04:38 +0800
From:	Baoquan He <bhe@...hat.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic
 entry found

On 09/29/15 at 03:50pm, Joerg Roedel wrote:
> On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote:
> > No need to continue the loop after it has been found.
> > 
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > ---
> >  drivers/iommu/intel_irq_remapping.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> > index 9ec4e0d..37b93f5 100644
> > --- a/drivers/iommu/intel_irq_remapping.c
> > +++ b/drivers/iommu/intel_irq_remapping.c
> > @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope, > >  		if (ir_ioapic[count].iommu == iommu &&
> >  		    ir_ioapic[count].id == scope->enumeration_id)
> >  			return 0;
> > -		else if (ir_ioapic[count].iommu == NULL && free == -1)
> > +		else if (ir_ioapic[count].iommu == NULL && free == -1) {
> >  			free = count;
> > +			break;
> > +		}
> >  	}
> 
> The purpose of the loop is also to avoid duplicate entries, so we need
> to search it till the end, no?

Ah, yes, you are right, it's on purpose. So I will drop this one
and update the 2/2 only with your suggestion.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/