linux-kernel - Re: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560AA56C.4020209@lab.ntt.co.jp>
Date:	Tue, 29 Sep 2015 23:51:24 +0900
From:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
To:	Yaowei Bai <bywxiaobai@....com>, viro@...iv.linux.org.uk
Cc:	linux-nilfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid_dev check

On 2015/09/28 23:33, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
> 
> Signed-off-by: Yaowei Bai <bywxiaobai@....com>

Acked-by: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>

> ---
>   fs/nilfs2/namei.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c
> index 37dd6b0..c9a1a49 100644
> --- a/fs/nilfs2/namei.c
> +++ b/fs/nilfs2/namei.c
> @@ -120,9 +120,6 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev)
>   	struct nilfs_transaction_info ti;
>   	int err;
>   
> -	if (!new_valid_dev(rdev))
> -		return -EINVAL;
> -
>   	err = nilfs_transaction_begin(dir->i_sb, &ti, 1);
>   	if (err)
>   		return err;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/