linux-kernel - Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150929154631.GA6489@bbox>
Date:	Tue, 29 Sep 2015 23:46:32 +0800
From:	Yaowei Bai <bywxiaobai@....com>
To:	Boaz Harrosh <ooo@...ctrozaur.com>
Cc:	viro@...iv.linux.org.uk, bhalevy@...marydata.com,
	osd-dev@...n-osd.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check

On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote:
> On 09/28/2015 04:43 PM, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@....com>
> 
> ACK-by: Boaz Harrosh <ooo@...ctrozaur.com>

Thanks.

> 
> Please submit this through some General tree like the vfs or mm-tree

This's my first fs-specific patch, so i think you mean i should cc vfs
or mm-tree?

> 
> Thanks
> Boaz
> 
> > ---
> >  fs/exofs/namei.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c
> > index 09a6bb1..994e078 100644
> > --- a/fs/exofs/namei.c
> > +++ b/fs/exofs/namei.c
> > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
> >  	struct inode *inode;
> >  	int err;
> >  
> > -	if (!new_valid_dev(rdev))
> > -		return -EINVAL;
> > -
> >  	inode = exofs_new_inode(dir, mode);
> >  	err = PTR_ERR(inode);
> >  	if (!IS_ERR(inode)) {
> > 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/