| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1443616515-17763-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Wed, 30 Sep 2015 13:35:15 +0100 From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> To: gregkh@...uxfoundation.org Cc: maxime.ripard@...e-electrons.com, linux-kernel@...r.kernel.org, srinivas.kandagatla@...aro.org, linux-arm-kernel@...ts.infradead.org, Axel Lin <axel.lin@...ics.com> Subject: [PATCH 2/4] nvmem: core: Handle shift bits in-place if cell->nbits is non-zero From: Axel Lin <axel.lin@...ics.com> It's pointless to test (cell->bit_offset || cell->bit_offset). nvmem_shift_read_buffer_in_place() should be called when (cell->bit_offset || cell->nbits). Signed-off-by: Axel Lin <axel.lin@...ics.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index f4af8e5..676607c 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -825,7 +825,7 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, return rc; /* shift bits in-place */ - if (cell->bit_offset || cell->bit_offset) + if (cell->bit_offset || cell->nbits) nvmem_shift_read_buffer_in_place(cell, buf); *len = cell->bytes; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists