| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1443616570-17825-1-git-send-email-srinivas.kandagatla@linaro.org> Date: Wed, 30 Sep 2015 13:36:10 +0100 From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> To: gregkh@...uxfoundation.org Cc: maxime.ripard@...e-electrons.com, linux-kernel@...r.kernel.org, srinivas.kandagatla@...aro.org, linux-arm-kernel@...ts.infradead.org, Axel Lin <axel.lin@...ics.com> Subject: [PATCH 3/4] nvmem: core: Fix memory leak in nvmem_cell_write From: Axel Lin <axel.lin@...ics.com> A tmp buffer is allocated if cell->bit_offset || cell->nbits. So the tmp buffer needs to be freed at the same condition to avoid leak. Signed-off-by: Axel Lin <axel.lin@...ics.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 676607c..6fd4e5a 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -938,7 +938,7 @@ int nvmem_cell_write(struct nvmem_cell *cell, void *buf, size_t len) rc = regmap_raw_write(nvmem->regmap, cell->offset, buf, cell->bytes); /* free the tmp buffer */ - if (cell->bit_offset) + if (cell->bit_offset || cell->nbits) kfree(buf); if (IS_ERR_VALUE(rc)) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists