| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Sep 2015 09:36:21 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Peter Zijlstra <peterz@...radead.org> Cc: mingo@...nel.org, linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org, fweisbec@...il.com, oleg@...hat.com, umgwanakikbuti@...il.com, tglx@...utronix.de Subject: Re: [PATCH v2 03/12] sched: Create preempt_count invariant On Wed, 30 Sep 2015 13:13:23 +0200 Peter Zijlstra <peterz@...radead.org> wrote: > On Wed, Sep 30, 2015 at 05:32:08AM -0400, Steven Rostedt wrote: > > On Wed, 30 Sep 2015 09:10:38 +0200 > > Peter Zijlstra <peterz@...radead.org> wrote: > > > -#ifdef CONFIG_PREEMPT_COUNT > > > -#define PREEMPT_DISABLED (1 + PREEMPT_ENABLED) > > > -#else > > > -#define PREEMPT_DISABLED PREEMPT_ENABLED > > > -#endif > > > +#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) > > > > Hmm, it looks to me that you removed all users of PREEMPT_DISABLED. > > > > Did you add another user of it? > > Dunno, lemme go grep ;-) > > include/linux/sched.h:#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) > kernel/sched/core.c: preempt_count_set(PREEMPT_DISABLED); > > So there still is one user. Ah, that's the one you added in patch 7. I did a git grep from the vanilla tree. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists